add option to count MAC (default to True) instead of flops #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D28859722 |
ppwwyyxx
added a commit
to ppwwyyxx/fvcore
that referenced
this pull request
Jul 8, 2021
…esearch#77) Summary: Pull Request resolved: facebookresearch#77 MACs and FLOPs are different concepts but often misused. This should make it more clear that FlopCounter is actually counting MACs. Maybe we should even change the default but that's a different decision to make. Differential Revision: D28859722 fbshipit-source-id: 794b1410a53c6e72c83a4abb2d1d660cd78517a9
|
This pull request was exported from Phabricator. Differential Revision: D28859722 |
ppwwyyxx
force-pushed
the
export-D28859722
branch
from
9d66701 to
726a919
Compare
…esearch#77) Summary: Pull Request resolved: facebookresearch#77 MACs and FLOPs are different concepts but often misused. This should make it more clear that FlopCounter is actually counting MACs. Maybe we should even change the default but that's a different decision to make. Differential Revision: D28859722 fbshipit-source-id: e0a1ec37ce1888a5ab8138edd9301e59959c3d8f
ppwwyyxx
force-pushed
the
export-D28859722
branch
from
726a919 to
0af9871
Compare
|
This pull request was exported from Phabricator. Differential Revision: D28859722 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MACs and FLOPs are different concepts but often misused.
This should make it more clear that FlopCounter is actually counting MACs.
Maybe we should even change the default but that's a different decision to make.
Differential Revision: D28859722